[spi device] remove _spi_bus_device_control#5898
Merged
Merged
Conversation
ShermanShao
reviewed
May 9, 2022
|
|
||
| return RT_EOK; | ||
| return result; | ||
| } |
Contributor
There was a problem hiding this comment.
因为在 SPI 驱动框架里，配置 SPI 总线设备用的是驱动里实现的 struct rt_spi_ops 里的 configure，
在这里实现的是 struct rt_device_ops 里的 control，其实并没有用到。
是不是可以在 init 时把这个ops 置 NULL，就直接不用实现了。
Guozhanxin
approved these changes
May 13, 2022
mysterywolf
changed the title
Guozhanxin
approved these changes
May 30, 2022
Contributor
|
+1 |
levizh
added a commit
to levizh/rt-thread
that referenced
this pull request
May 31, 2022
…hc32_pr * 'master' of https://github.com/RT-Thread/rt-thread: Hc32 pr (RT-Thread#6003) [add] winsock implement on windows simulator. (RT-Thread#6010) [spi device] remove _spi_bus_device_control (RT-Thread#5898) [net][lwip] Support windows simulator (RT-Thread#5993) [componnets][pin]add pin operate command in MSH (RT-Thread#5892) [device][adc] implement adc_get_vref (RT-Thread#5988) [drivers][hwcrypto] Correct function return value definition (RT-Thread#5984) [STM32][RTC] add support for STM32L0 series. (RT-Thread#5994) Fix bug when restarting and getting interrupts that are not processed. (RT-Thread#5997) [kernel][timer] fixed bug (RT-Thread#6004)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
_spi_bus_device_control 该函数没有实际被使用到予以移除
一些设备框架的错误码返回值处理不是很仔细，在没有任何有效操作的情况下，也会返回RT_EOK，这对用户的误导非常大。
今天在调试的时候顺道发现了spi control存在类似的问题。
此外在论坛上也有此类问题的反应：http://bbs.eeworld.com.cn/thread-1196113-1-1.html
考虑在4.1.1之前对此类问题进行一次摸排
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up